Avoid memcpy()-ing 0-length vectors
#6820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C standard (before C23) says that giving invalid pointers, even with length=0, to memcpy() is undefined behaviour. R returns an invalid pointer for vectors of length 0, so avoid calls to memcpy() altogether in such cases.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6820 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 79 79
Lines 14642 14650 +8
=======================================
+ Hits 14444 14452 +8
Misses 198 198 ☔ View full report in Codecov by Sentry. |
|
Generated via commit 4773ceb Download link for the artifact containing the test results: ↓ atime-results.zip
|
MichaelChirico
approved these changes
Feb 21, 2025
Member
MichaelChirico
left a comment
MichaelChirico
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge whether or not you want to make my suggested change.
Do we have any way of preventing this from recurring in the future?
Co-authored-by: Michael Chirico <[email protected]>
Co-authored-by: Michael Chirico <[email protected]>
Member
Author
|
Maybe not literally preventing, but a sanitizer-enabled CI check should be able to catch similar problems as soon as they land on Then why does |
aitap
added a commit
that referenced
this pull request
May 21, 2025
* Avoid memcpy()-ing 0-length vectors The C standard (before C23) says that giving invalid pointers, even with length=0, to memcpy() is undefined behaviour. R returns an invalid pointer for vectors of length 0, so avoid calls to memcpy() altogether in such cases. * Use early returns for 0-length cases Co-authored-by: Michael Chirico <[email protected]>
TysonStanley
pushed a commit
that referenced
this pull request
May 25, 2025
* Avoid memcpy()-ing 0-length vectors The C standard (before C23) says that giving invalid pointers, even with length=0, to memcpy() is undefined behaviour. R returns an invalid pointer for vectors of length 0, so avoid calls to memcpy() altogether in such cases. * Use early returns for 0-length cases Co-authored-by: Michael Chirico <[email protected]>
MichaelChirico
added a commit
that referenced
this pull request
May 26, 2025
* Avoid `memcpy()`-ing 0-length vectors (#6820) * Avoid memcpy()-ing 0-length vectors The C standard (before C23) says that giving invalid pointers, even with length=0, to memcpy() is undefined behaviour. R returns an invalid pointer for vectors of length 0, so avoid calls to memcpy() altogether in such cases. * Use early returns for 0-length cases Co-authored-by: Michael Chirico <[email protected]> * Avoid memcpy() of empty vector (#6911) * Avoid memcpy() of empty vector * in getidcols() too * Add a test case Distilled from the `melt()` call here: https://github.com/gdemin/expss/blob/d498caf72a9938ac71b9e06fd61485cd0347d607/tests/testthat/test_subtotal.R#L161-L166 * NEWS entry --------- Co-authored-by: Michael Chirico <[email protected]> Co-authored-by: Michael Chirico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C standard (before C23) says that giving invalid pointers, even with length=0, to
memcpy()is undefined behaviour. R returns an invalid pointer for vectors of length 0, so avoid calls tomemcpy()altogether in such cases.Fixes: #6819